Remove /bin/sh from Documenation #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jan 24, 2023
| @@ -181,7 +181,7 @@ docker run \ | |||
| To run `etcdctl` using API version 3: | |||
|
|
|||
| ``` | |||
| docker exec etcd /bin/sh -c "export ETCDCTL_API=3 && /usr/local/bin/etcdctl put foo bar" | |||
| docker exec etcd export ETCDCTL_API=3 && /usr/local/bin/etcdctl put foo bar | |||
There was a problem hiding this comment.
etcd main branch (3.6) doesn't need ETCDCTL_API any more.
Suggested change
| docker exec etcd export ETCDCTL_API=3 && /usr/local/bin/etcdctl put foo bar | |
| docker exec etcd /usr/local/bin/etcdctl put foo bar |
|
Thank you @nickmancari for the PR. Please
|
|
You only signed the third commit, the other two commits are not signed yet. Please squash the commits into just one commit and signoff the final commit. |
removed ETCDCTL_API also fixed v3.5 and v3.4 Signed-off-by: Nick Mancari <[email protected]>
nickmancari
force-pushed
the
bin-sh-documentation-update
branch
from
ac512d7 to
1be83b2
Compare
|
Squashed commits and signed |
NotAwar
pushed a commit
to NotAwar/website
that referenced
this pull request
Feb 27, 2025
…update Remove /bin/sh from Documenation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the reference to
\bin\shto accurately reflect changes in v3.7etcd-io/etcd#15173