-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc_naming.md round-robin strategy #633
Conversation
…ick first will be used. It would be nice to point out how to use round-robin load balancing. Signed-off-by: Ramil Mirhasanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But ideally we should have a test if we are making it an officially supported use-case. |
Good point! I've opened a draft here for a new case etcd-io/etcd#15577. We can finish and merge that if there is broader consensus that it's worthwhile to support round robin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
```go | ||
|
||
conn, gerr := grpc.Dial("etcd:///foo", grpc.WithResolvers(etcdResolver), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually Resolver is an experimental gRPC API, and we need to remove the dependency on it. FYI. etcd-io/etcd#15145
I am OK to merge this PR firstly, and update it when etcd-io/etcd#15145 is done.
cc @spzala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr thanks and that sounds good to me too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
```go | ||
|
||
conn, gerr := grpc.Dial("etcd:///foo", grpc.WithResolvers(etcdResolver), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahrtr thanks and that sounds good to me too!
when using new resolver from /client/v3/naming/resolver , default grpc load balancing strategy: pick first will be used. It would be nice to point out how to use round-robin load balancing.
Signed-off-by: Ramil Mirhasanov [email protected]