step down when leader removes itself #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbg
approved these changes
Jun 26, 2023
|
@erikgrinaker please rebase this PR, I will take a look tomorrow. |
This patch causes a leader to step down when it removes itself from the group, becoming a follower in the current term. We don't want a removed leader to remain a leader: it no longer accepts proposals, so if it keeps heartbeating then the group is effectively stuck. Signed-off-by: Erik Grinaker <[email protected]>
erikgrinaker
force-pushed
the
remove-leader-step-down
branch
from
507495e to
72d62a1
Compare
|
TFTR! |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 17, 2023
Picks up - etcd-io/raft#77 - etcd-io/raft#79 (essentially an off-by-default for 77) - etcd-io/raft#82 - etcd-io/raft#81 (needed for cockroachdb#105797) Epic: none Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This behavior was later gated behind a config option in #79.
This patch causes a leader to step down when it removes itself from the group, becoming a follower in the current term. We don't want a removed leader to remain a leader: it no longer accepts proposals, so if it keeps heartbeating then the group is effectively stuck.
Signed-off-by: Erik Grinaker [email protected]
cc @tbg @pavelkalinnikov