-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EtcdLease should not use ListenableFuture directly #46
Comments
@lburgazzoli thanks for the notification. I will also check #16. I have a patch to shade Guava into jetcd locally, so I can send a PR soon. However, it can increase the size of binary. Can we accept it? |
I do not know, but having had quite a few issues with guava dependencies I would really like not to do it again ;) |
Thanks for your comment. I agree with you. Created #47. I appreciate if you take look. |
add keepaliveonce implementation
closing via #109 |
Currently, EtcdLease exposes com.google.common.util.concurrent.ListenableFuture as a part of API. If ListenableFuture is used directly, it will conflict with user-side guava library. Instead, ListenableSetFuture in #45 or some wrapper class in com.coreos.jetcd should be used to avoid the problem.
The text was updated successfully, but these errors were encountered: