Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EtcdLease should not use ListenableFuture directly #46

Closed
oza opened this issue Sep 1, 2016 · 5 comments
Closed

EtcdLease should not use ListenableFuture directly #46

oza opened this issue Sep 1, 2016 · 5 comments

Comments

@oza
Copy link
Contributor

oza commented Sep 1, 2016

Currently, EtcdLease exposes com.google.common.util.concurrent.ListenableFuture as a part of API. If ListenableFuture is used directly, it will conflict with user-side guava library. Instead, ListenableSetFuture in #45 or some wrapper class in com.coreos.jetcd should be used to avoid the problem.

@lburgazzoli
Copy link
Collaborator

This is related to #16.
IMHO best would be to shade guava and use CompletableFutures as suggested by @jurmous

@oza
Copy link
Contributor Author

oza commented Sep 1, 2016

@lburgazzoli thanks for the notification. I will also check #16.

I have a patch to shade Guava into jetcd locally, so I can send a PR soon. However, it can increase the size of binary. Can we accept it?

@lburgazzoli
Copy link
Collaborator

I do not know, but having had quite a few issues with guava dependencies I would really like not to do it again ;)

@oza oza mentioned this issue Sep 1, 2016
@oza
Copy link
Contributor Author

oza commented Sep 1, 2016

Thanks for your comment. I agree with you. Created #47. I appreciate if you take look.

@fanminshi
Copy link
Member

closing via #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants