CHANGELOG: Add 3.4 changelog entry for snapshot file permissions change #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the release note for #9977. I'm a little unsure as to where to put the note. Please let me know if I should move this note--or add another note--to a different section. Thanks! |
|
Agree with @hexfusion. Let's also mention this in breaking changes section, to be safe. |
|
@dlipovetsky, just also add this note to the client-v3 section of the doc rebase and we are good. Thanks! https://github.com/coreos/etcd/blob/master/CHANGELOG-3.4.md#client-v3 |
dlipovetsky
force-pushed
the
snapshot-file-permission-release-note
branch
from
254391d to
f52a990
Compare
|
@hexfusion and @gyuho Thanks for reviewing. I put the note in both the "breaking changes" and "client v3" sections. |
gyuho
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.