Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update "grpc-gateway" to v1.4.0 #9756

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 23, 2018

We forgot to update the actual Go dependencies from #9755.

@codecov-io
Copy link

Codecov Report

Merging #9756 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9756      +/-   ##
==========================================
+ Coverage   68.64%   69.26%   +0.61%     
==========================================
  Files         374      375       +1     
  Lines       35129    35179      +50     
==========================================
+ Hits        24114    24365     +251     
+ Misses       9242     9047     -195     
+ Partials     1773     1767       -6
Impacted Files Coverage Δ
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
pkg/adt/interval_tree.go 79.87% <0%> (-12.02%) ⬇️
etcdctl/ctlv3/command/lease_command.go 65.34% <0%> (-5.95%) ⬇️
integration/bridge.go 70.22% <0%> (-1.53%) ⬇️
lease/leasehttp/http.go 56.61% <0%> (-1.48%) ⬇️
clientv3/balancer/grpc1.7-health.go 84.88% <0%> (-1.46%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 72.48% <0%> (-1.35%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
client/client.go 83.66% <0%> (-0.99%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216e8e4...c77223f. Read the comment docs.

@hexfusion
Copy link
Contributor

hexfusion commented May 23, 2018

@gyuho I see now. They cut 1.4.1 last night which has a feature that would allow us to output swagger to a single JSON file vs 3. grpc-ecosystem/grpc-gateway#658 If that seems reasonable I have cut a PR #9757.

Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hexfusion
Copy link
Contributor

I am going to merge so the repo is stable we can look at 1.4.1 PR later.

@hexfusion hexfusion merged commit 20b1a98 into etcd-io:master May 23, 2018
@gyuho gyuho deleted the grpc-gateway branch May 23, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants