Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot: use structured logger #9538

Merged
merged 2 commits into from
Apr 6, 2018
Merged

snapshot: use structured logger #9538

merged 2 commits into from
Apr 6, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 6, 2018

In the process of removing capnslog

Address #9438

gyuho added 2 commits April 6, 2018 10:59
In the process of removing capnslog

Signed-off-by: Gyuho Lee <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #9538 into master will increase coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9538      +/-   ##
==========================================
+ Coverage   72.39%   72.39%   +<.01%     
==========================================
  Files         367      367              
  Lines       31267    31277      +10     
==========================================
+ Hits        22635    22643       +8     
- Misses       7000     7003       +3     
+ Partials     1632     1631       -1
Impacted Files Coverage Δ
etcdctl/ctlv3/command/snapshot_command.go 67% <50%> (ø) ⬆️
snapshot/v3_snapshot.go 63.71% <88.88%> (+0.75%) ⬆️
etcdctl/ctlv2/command/role_commands.go 39.88% <0%> (-17.27%) ⬇️
auth/simple_token.go 87.03% <0%> (-6.49%) ⬇️
pkg/logutil/discard_logger.go 6.25% <0%> (-6.25%) ⬇️
etcdserver/api/v3rpc/watch.go 76.59% <0%> (-4.69%) ⬇️
etcdserver/api/v3rpc/lease.go 77.02% <0%> (-4.06%) ⬇️
clientv3/concurrency/election.go 79.52% <0%> (-2.37%) ⬇️
raft/progress.go 94.17% <0%> (-1.95%) ⬇️
clientv3/balancer/grpc1.7-health.go 85.17% <0%> (-1.46%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91a61b...18b1d1f. Read the comment docs.

@gyuho gyuho merged commit c54636a into etcd-io:master Apr 6, 2018
@gyuho gyuho deleted the lll branch April 6, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants