raft: Clarify conditions for granting votes and prevotes. #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes one theoretical logic change: A node that knows the leader of the current term will no longer grant votes, even if it has not yet voted in this term. It also adds a `m.Type == MsgPreVote` guard on the `m.Term > r.Term` check, which was previously thought to be incorrect (see etcd-io#8517) but was actually just unclear. Closes etcd-io#8517 Closes etcd-io#8571
|
lgtm. thanks. |
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Jan 28, 2018
This picks up some changes to prevote (etcd-io/etcd#8525 and etcd-io/etcd#9204), as well as a new ErrProposalDropped that we're not yet using. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes one theoretical logic change: A node that knows the
leader of the current term will no longer grant votes, even if it has
not yet voted in this term. It also adds a
m.Type == MsgPreVoteguard on the
m.Term > r.Termcheck, which was previously thought tobe incorrect (see #8517) but was actually just unclear.
Closes #8517
Closes #8571