Documentation/dev-guide: update "Request size limit" with v3.2.12 #9129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9129 +/- ##
=========================================
Coverage ? 75.96%
=========================================
Files ? 359
Lines ? 30004
Branches ? 0
=========================================
Hits ? 22793
Misses ? 5621
Partials ? 1590Continue to review full report at Codecov.
|
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Request size limit | |||
|
|
|||
| etcd is designed to handle small key value pairs typical for metadata. Larger requests will work, but may increase the latency of other requests. For the time being, etcd guarantees to support RPC requests with up to 1MB of data. In the future, the size limit may be loosened or made configurable. | |||
There was a problem hiding this comment.
the sever side data limit is still 1MB i believe.
There was a problem hiding this comment.
Users will not care about what gRPC limits. They care about the size of key+value in put or in transaction. let us put 1.5Mi there, and keep the previous working (not mentioning gRPC client thing here.)
Documentation/dev-guide/limit.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Request size limit | |||
|
|
|||
| etcd is designed to handle small key value pairs typical for metadata. Larger requests will work, but may increase the latency of other requests. For the time being, etcd guarantees to support RPC requests with up to 1MB of data. In the future, the size limit may be loosened or made configurable. | |||
| etcd is designed to handle small key value pairs typical for metadata. Larger requests will work, but may increase the latency of other requests. As of v3.2.12, etcd guarantees to support client RPC requests of 2 MiB, by default. The client size limit is configurable via `clientv3.Config.MaxCallSendMsgSize`, with corresponding "--max-request-bytes" flag for etcd server. | |||
There was a problem hiding this comment.
@gyuho a small observation, "--max-request-bytes" should change to --max-request-bytes. Thanks!
gyuho
force-pushed
the
doc
branch
2 times, most recently
from
3f7fe52 to
854320e
Compare
|
@xiang90 PTAL. |
Documentation/dev-guide/limit.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Request size limit | |||
|
|
|||
| etcd is designed to handle small key value pairs typical for metadata. Larger requests will work, but may increase the latency of other requests. For the time being, etcd guarantees to support RPC requests with up to 1MB of data. In the future, the size limit may be loosened or made configurable. | |||
| etcd is designed to handle small key value pairs typical for metadata. Larger requests will work, but may increase the latency of other requests. As of v3.2.12, etcd guarantees to support client RPC requests of 1.5 MiB, by default. The client size limit is configurable via `clientv3.Config.MaxCallSendMsgSize`, with corresponding `--max-request-bytes` flag for etcd server. | |||
There was a problem hiding this comment.
etcd is designed to handle small key value pairs typical for metadata. Larger requests will work, but may increase the latency of other requests. By default, the maximum size of any request is 1.5 MiB. This limit is configurable through --max-request-bytes flag for etcd server.
There was a problem hiding this comment.
@gyuho if you want to add more documentation on the client side limit. submit a new PR for that and put it into a separate section. i do not want to mix server/client together.
There was a problem hiding this comment.
Ok sounds good. Will separate out.
Signed-off-by: Gyuho Lee <[email protected]>
|
lgtm |
No description provided.