Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed: fix *grpc.Server panic on GracefulStop with TLS-enabled server #8987

Merged
merged 3 commits into from
Dec 8, 2017
Merged

embed: fix *grpc.Server panic on GracefulStop with TLS-enabled server #8987

merged 3 commits into from
Dec 8, 2017

Commits on Dec 8, 2017

  1. embed: Avoid panic when shutting down gRPC Server 

    Avoid panic when stopping gRPC Server if TLS configuration is present.
Provided solution (attempts to) implement suggestion from gRPC team: grpc/grpc-go#1384 (comment).

Fixes etcd-io#8916
    @jamesdphillips @gyuho
    jamesdphillips authored and gyuho committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    e39915f View commit details
    Browse the repository at this point in the history

  2. embed: only gracefully shutdown insecure grpc.Server 

    Signed-off-by: Gyuho Lee <[email protected]>
    @gyuho
    gyuho committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    552b58d View commit details
    Browse the repository at this point in the history

  3. integration: test GracefulStop on secure embedded server 

    Signed-off-by: Gyuho Lee <[email protected]>
    @gyuho
    gyuho committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    9bd07c9 View commit details
    Browse the repository at this point in the history