lease: test minLeaseTTL limit #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
suggested changes
Sep 12, 2017
lease/lessor_test.go
Outdated
| @@ -45,10 +45,16 @@ func TestLessorGrant(t *testing.T) { | |||
| defer le.Stop() | |||
| le.Promote(0) | |||
|
|
|||
| l, err := le.Grant(1, 1) | |||
| ttl := int64(1) // ttl <= minLeaseTTL in this test case | |||
There was a problem hiding this comment.
please don't introduce this new variable, there's more changes from adding ttl than code for what this patch is testing
Test whether lease's ttl is set to minLeaseTTL when passing a ttl smaller than minLeaseTTL to Grant function.
|
I have removed |
Codecov Report
@@ Coverage Diff @@
## master #8537 +/- ##
=========================================
Coverage ? 66.02%
=========================================
Files ? 360
Lines ? 29551
Branches ? 0
=========================================
Hits ? 19511
Misses ? 8373
Partials ? 1667Continue to review full report at Codecov.
|
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test whether lease's ttl is set to minLeaseTTL when passing a ttl smaller than minLeaseTTL to Grant function.