functional-tester: move checker logic to cluster #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Oct 18, 2016
| } | ||
|
|
||
| func newHashChecker(tt *tester) Checker { return &hashChecker{tt} } | ||
| func newHashChecker(c *cluster) Checker { return &hashChecker{hashAndRevGetter(c)} } |
There was a problem hiding this comment.
change this to newHashChecker(hrg hashAndRevGetter) convert cluster to hrg outside the new func. it is cleaner.
xiang90
reviewed
Oct 18, 2016
|
|
||
| func (hc *hashChecker) Check() (err error) { | ||
| plog.Printf("%s fetching current revisions...", hc.tt.logPrefix()) |
There was a problem hiding this comment.
@gyuho do we still want this log prefix thing?
xiang90
reviewed
Oct 18, 2016
| Members []*member | ||
|
|
||
| stressBuilder stressBuilder | ||
| agents []agentConfig |
There was a problem hiding this comment.
still keep the empty space between different fields sections?
|
LGTM. defer to @gyuho |
xiang90
reviewed
Oct 18, 2016
| @@ -24,14 +24,18 @@ type Checker interface { | |||
| Check() error | |||
| } | |||
|
|
|||
| type hashAndRevGetter interface { | |||
| getRevisionHash() (map[string]int64, map[string]int64, error) | |||
There was a problem hiding this comment.
probably name the returned stuff.
xiang90
reviewed
Oct 18, 2016
| @@ -109,6 +101,12 @@ func (c *cluster) bootstrap() error { | |||
| go c.Stressers[i].Stress() | |||
| } | |||
|
|
|||
| if c.consistencyCheck && !c.v2Only { | |||
| c.Checker = newHashChecker(c) | |||
There was a problem hiding this comment.
newHashChecker(hashAndRevGetter(c)) so you know that you do not give the hashchecker access to all methods on cluster.
I move the checker logic from tester to cluster so that stressers and checkers can be initialized at the same time. this is useful because some checker depends on stressers.
fanminshi
force-pushed
the
function-tester-refractor
branch
from
f3b4344 to
7d86d10
Compare
|
lgtm. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I move the checker logic from tester to cluster so that stressers and checkers can be initialized at the same time.
this is useful because some checker depends on stressers.