etcdserver: Range with min/max mod revision #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,6 +280,12 @@ func WithCountOnly() OpOption { | |||
| return func(op *Op) { op.countOnly = true } | |||
| } | |||
|
|
|||
| // WithMinModRev filters out keys with modification revisions less than the given revision. | |||
There was a problem hiding this comment.
add a comment about this option only works for range request? users might think this would work for deleterange.
|
lgtm |
heyitsanthony
force-pushed
the
v3api-minmaxmod
branch
from
f5a9cae to
17e7f83
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5412. Mainly in response to #6408 since the current Mutex code has some gross hacks to work around the lack of min/max mod rev. RWMutex would need to inherit those hacks to work, so might as well update the API so it can be done cleanly.