Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3api, rpctypes: add ErrUnhealthy #6382

Merged
merged 1 commit into from
Sep 8, 2016
Merged

v3api, rpctypes: add ErrUnhealthy #6382

merged 1 commit into from
Sep 8, 2016

Conversation

heyitsanthony
Copy link
Contributor

@xiang90
Copy link
Contributor

xiang90 commented Sep 7, 2016

lgtm

@gyuho
Copy link
Contributor

gyuho commented Sep 8, 2016

LGTM.

Where is this error type used? Is it just for external project?

@hongchaodeng
Copy link
Contributor

Let me try this patch tomorrow

@hongchaodeng hongchaodeng self-assigned this Sep 8, 2016
@hongchaodeng
Copy link
Contributor

@gyuho
If we just changed membership, second AddMember() will encounter this failure.
From user's perspective, we can retry on such transient error.

@heyitsanthony
Thanks for the quick fix!

@hongchaodeng
Copy link
Contributor

Verified.
LGTM

@heyitsanthony heyitsanthony merged commit 4563efd into etcd-io:master Sep 8, 2016
@heyitsanthony heyitsanthony deleted the unhealthy-err branch September 8, 2016 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyitsanthony @xiang90 @gyuho @hongchaodeng