Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpcproxy: fix double create event #6340

Merged
merged 1 commit into from
Sep 2, 2016
Merged

grpcproxy: fix double create event #6340

merged 1 commit into from
Sep 2, 2016

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Sep 2, 2016

heyitsanthony
heyitsanthony reviewed Sep 2, 2016
View reviewed changes
proxy/grpcproxy/watcher_groups.go
@@ -43,6 +43,14 @@ func (wgs *watchergroups) addWatcher(rid receiverID, w watcher) {
rev := wg.add(rid, w)
wgs.idToGroup[rid] = wg

// The group is newly created, the create event has not been delievered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delivered/delivered

@xiang90
Copy link
Contributor Author

xiang90 commented Sep 2, 2016

@heyitsanthony PTAL.

@heyitsanthony
Copy link
Contributor

lgtm

@xiang90 xiang90 merged commit 0d07154 into etcd-io:master Sep 2, 2016
@xiang90 xiang90 deleted the fix_double_create branch September 2, 2016 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiang90 @heyitsanthony