integration: NewClusterV3() should launch cluster before creating clients #6222
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timothysc |
|
lgtm |
1 task
|
@hongchaodeng we'll need to rev the godeps again... |
|
@gyuho Can we cherry-pick this to 3.0 branch? |
|
I am backporting this to |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Aug 21, 2016
Automatic merge from submit-queue godep: bump etcd to 3.0.6 What? Bump etcd godep dependency to v3.0.6 Why? ref: #30843, etcd-io/etcd#6222 We have some fix to do secure client connection in unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It changes NewClusterV3() to launch the cluster before creating clients.
Why?
Previously, NewClientV3() didn't have client connections established but kept retrying. If we have TLS handshake, it failed because it would block and return error.