wal: Export SegmentSizeBytes as a variable #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // warnSyncDuration is the amount of time allotted to an fsync before | ||
| // logging a warning | ||
| warnSyncDuration = time.Second | ||
| ) | ||
|
|
||
| var ( | ||
| // SegmentSizeBytes is the expected size of each wal segment file. |
There was a problem hiding this comment.
s/expected/preallocated
There was a problem hiding this comment.
Changed this. Thanks for the quick review.
|
lgtm after fixing minor comment nit and ci passes. Thanks! |
In test situations, it's useful to create smaller than usual WAL files to test rotation and to avoid the overhead of preallocation on old-style filesystems that don't handle it efficiently. This commit changes segmentSizeBytes to an exported variable so that tests can override it from an init() function.
aaronlehmann
force-pushed
the
export-segment-size
branch
from
26aa9bc to
2b996b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test situations, it's useful to create smaller than usual WAL files
to test rotation and to avoid the overhead of preallocation on old-style
filesystems that don't handle it efficiently. This commit changes
segmentSizeBytes to an exported variable so that tests can override it
from an init() function.
Fixes: #6138