raft: refactor inflight #4931
raft: refactor inflight #4931
Conversation
| @@ -64,12 +64,17 @@ type Progress struct { | |||
| RecentActive bool | |||
|
|
|||
| // inflights is a sliding window for the inflight messages. | |||
| // Each inflight message might contain more than one entries | |||
| // and has a size limit defined in raft config as MaxSizePerMsg. | |||
There was a problem hiding this comment.
A size limit in number of bytes or number of entries? I'm again confused about the purpose of this whole thing. Are the number of bytes tracked anywhere?
There was a problem hiding this comment.
Sorry... So a message contains one or multiple raft entries. Each message has a max size.
Say leader sends 8 entries with 1MB per entries. For each message, the max size is 4MB. With flow control, two messages with entries [1,2,3,4] and [5,6,7,8] will be sent. We will have [4, 8] in inflights.
Once follower replies with index 8, then we clear 4 and 8 from inflights together.
There was a problem hiding this comment.
I am considering to just make this a direct bytes based control. But it requires some changes from the upper level rafthttp, which now has a message based buffer (N number of messages).
|
@philips, I mentioned this one last night, I think you wanted to take a look |
|
@xiang90 Shall we merge this? Low risk. lgtm. |
| @@ -183,14 +188,13 @@ type inflights struct { | |||
| // number of inflights in the buffer | |||
| count int | |||
|
|
|||
| // the size of the buffer | |||
| size int | |||
| // buffer contains the index of the last entry | |||
There was a problem hiding this comment.
Would it be better to word
// buffer contains the last entry indexes of each message.
Fix #4899
/cc @bdarnell @ngaut @ongardie @superfell