-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: build phony etcd server binary for unsupported architectures #4721
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright 2016 CoreOS, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// +build !amd64 | ||
|
||
package etcdmain | ||
|
||
import ( | ||
"fmt" | ||
"os" | ||
|
||
"github.com/coreos/etcd/Godeps/_workspace/src/github.com/coreos/pkg/capnslog" | ||
) | ||
|
||
var plog = capnslog.NewPackageLogger("github.com/coreos/etcd", "etcdmain") | ||
|
||
func Main() { | ||
fmt.Println("unsupported architecture; unreliable, unstable") | ||
os.Exit(-1) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,5 +30,5 @@ import ( | |
// silently ignore this flag. Please update your kernel to prevent this. | ||
var boltOpenOptions = &bolt.Options{ | ||
MmapFlags: syscall.MAP_POPULATE, | ||
InitialMmapSize: InitialMmapSize, | ||
InitialMmapSize: int(InitialMmapSize), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will make There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, that was not the reason for the test failure. I tested it with a 256MB mmap reservation and it still failed. Likewise, go playground compiles with arch "amd64p32", which is why the ints are getting truncated. I tested on an amd64 arch and it gives the correct 64-bit value. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are you changing this anyway? AFAIU it worked fine on amd64 before. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bolt.Options expects an |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: support arm64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure