Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godeps: update boltdb/bolt for MAP_POPULATE #3858

Merged
merged 1 commit into from
Nov 12, 2015

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 12, 2015

This is for boltdb/bolt#455.

Please let me know if you have any feedback.

@xiang90
Copy link
Contributor

xiang90 commented Nov 12, 2015

Do you know why there are a lot of tests.go got removed?

@gyuho
Copy link
Contributor Author

gyuho commented Nov 12, 2015

Ah, I go get -v -u the bolt. I will clone it instead.

@xiang90
Copy link
Contributor

xiang90 commented Nov 12, 2015

@gyuho No problem. Thanks.

@gyuho
Copy link
Contributor Author

gyuho commented Nov 12, 2015

@xiang90 And I forgot the -t flag in godep update. Should be there now. Thanks,

@xiang90
Copy link
Contributor

xiang90 commented Nov 12, 2015

LGTM

@gyuho
Copy link
Contributor Author

gyuho commented Nov 12, 2015

Thanks, once merged, I will do some benchmarks to make sure it benefits the backend package.

@xiang90
Copy link
Contributor

xiang90 commented Nov 12, 2015

@gyuho You need to change the backend code to utilize the new feature first. :)

xiang90 added a commit that referenced this pull request Nov 12, 2015
Godeps: update boltdb/bolt for MAP_POPULATE
@xiang90 xiang90 merged commit 5acf557 into etcd-io:master Nov 12, 2015
@gyuho gyuho deleted the godep_bolt_20151112 branch January 31, 2016 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants