storage: fix hash by iterating kv #3585
Merged
+33
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @gyuho |
|
Ah! That's what was happening. |
| b := tx.Bucket(next) | ||
| if b == nil { | ||
| return fmt.Errorf("cannot get hash of bucket %s", string(next)) | ||
| } |
There was a problem hiding this comment.
could we write the name of bucket into crc32 too?
Closed
|
👍 Amazing to find this out. |
|
LGTM after ci pass |
xiang90
added a commit
that referenced
this pull request
Sep 23, 2015
storage: fix hash by iterating kv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child buckets are stored in a
mapin-memory during a transaction and iterated over when flushed. there’s no ordering guarantee of maps in Go. so the snapshot data might be different even if the kv are identical.