Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): update GitHub release related instructions #18887

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Nov 12, 2024

As noted in 2024-11-12 releases:

  1. Add instructions on how to verify that GitHub authentication works.
  2. Detail the steps on how to release the GitHub release.

Link to #18846.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

As noted in 2024-11-12 releases:

1. Add instructions on how to verify that GitHub authentication works.
2. Detail the steps on how to release the GitHub release.

Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc ivanvc force-pushed the update-release-documentation branch from 45b6e20 to d270546 Compare November 12, 2024 23:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (1316f3a) to head (8a8ce41).

Current head 8a8ce41 differs from pull request most recent head d270546

Please upload reports for the commit d270546 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 16 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18887      +/-   ##
==========================================
- Coverage   68.77%   68.65%   -0.12%     
==========================================
  Files         420      420              
  Lines       35532    35532              
==========================================
- Hits        24438    24396      -42     
- Misses       9661     9704      +43     
+ Partials     1433     1432       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1316f3a...d270546. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the improvement.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 19aa0db into etcd-io:main Nov 13, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants