Relax assumptions about all client request persisted in WAL to only require first and last request to be persisted #17966
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equire first and last request to be persisted This assumption is not true during durability issues like etcd-io#14370. In reality we want to avoid situations where WAL is was truncated, for that it's enough that we ensure that first and last operations are present. Found it when running `make test-robustness-issue14370` and instead of getting `Model is not linearizable` I got that assumptions were broken. Signed-off-by: Marek Siarkowicz <[email protected]>
|
/retest |
siyuanfoundation
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumption is not true during durability issues like #14370. In reality we want to avoid situations where WAL is was truncated, for that it's enough that we ensure that first and last operations are present.
Found it when running
make test-robustness-issue14370and instead of gettingModel is not linearizableI got that assumptions were broken, which is harder to understand.cc @siyuanfoundation @MadhavJivrajani @fuweid