github/workflows: remove golangci-lint-action step from static-analysis #17941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golangci-lint-action step runs only on the repository's top-level directory. Then, make verify reruns it on the same directory, which is redundant. However, to keep make verify target working, golangci-lint needs to be installed locally. Signed-off-by: Ivan Valdes <[email protected]>
|
The job still works, as shown in the job summary: https://github.com/etcd-io/etcd/actions/runs/8963530645/job/24613946859?pr=17941 /cc @jmhbnz |
jmhbnz
reviewed
May 6, 2024
jmhbnz
approved these changes
May 6, 2024
fuweid
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golangci-lint-action step runs only on the repository's top-level directory. Then,
make verifyreruns it on the same directory, which is redundant.However, to keep
make verifytarget working,golangci-lintneeds to be installed locally.Fixes #17929
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.