Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation comments from addressing var-naming work #17875

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Apr 24, 2024

The deprecation tag/comment must be followed by an empty line, as prompted in #17674 (comment).

Part of #17578.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The deprecation tag/comment must to be followed by an empty line.

Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc ivanvc mentioned this pull request Apr 24, 2024
20 tasks
@ahrtr ahrtr merged commit 09f7d7a into etcd-io:main Apr 30, 2024
43 checks passed
@ivanvc ivanvc deleted the fix-deprecation-comments-added-with-var-naming-lint-rule branch April 30, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants