Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address remaining var naming linter warnings #17863

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Apr 24, 2024

This is the last PR from #17578, before enabling the linter. Addresses miscellaneous violations in etcdutl, tools/etcd-dump-logs, and tests/common.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ivanvc ivanvc mentioned this pull request Apr 24, 2024
20 tasks
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ahrtr ahrtr merged commit a601652 into etcd-io:main Apr 24, 2024
43 checks passed
@ivanvc ivanvc deleted the address-remaining-var-naming-linter-warnings branch April 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants