server/embed: address golangci var-naming issues #17820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issues in ListenPeerUrls, ListenClientUrls, ListenClientHttpUrls, AdvertisePeerUrls, AdvertiseClientUrls. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
commented
Apr 18, 2024
Comment on lines
-452
to
+459
| ListenPeerUrls string `json:"listen-peer-urls"` | ||
| ListenClientUrls string `json:"listen-client-urls"` | ||
| ListenClientHttpUrls string `json:"listen-client-http-urls"` | ||
| AdvertisePeerUrls string `json:"initial-advertise-peer-urls"` | ||
| AdvertiseClientUrls string `json:"advertise-client-urls"` | ||
| ListenPeerURLs string `json:"listen-peer-urls"` | ||
| ListenClientURLs string `json:"listen-client-urls"` | ||
| ListenClientHTTPURLs string `json:"listen-client-http-urls"` | ||
| AdvertisePeerURLs string `json:"initial-advertise-peer-urls"` | ||
| AdvertiseClientURLs string `json:"advertise-client-urls"` |
There was a problem hiding this comment.
As stated in the PR description, these are exported fields from an unexported struct. It's internally used to marshal/unmarshal JSONs. So, it should be fine to rename.
ivanvc
commented
Apr 18, 2024
Comment on lines
+64
to
+67
| ListenPeerURLs string `json:"listen-peer-urls"` | ||
| ListenClientURLs string `json:"listen-client-urls"` | ||
| ListenClientHTTPURLs string `json:"listen-client-http-urls"` | ||
| AdvertiseClientURLs string `json:"advertise-client-urls"` |
There was a problem hiding this comment.
As stated in the PR description, these are used only for tests marshaling the config into JSON, so it should be safe to rename them.
20 tasks
|
/retest |
serathius
approved these changes
Apr 19, 2024
ahrtr
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues in ListenPeerUrls, ListenClientUrls, ListenClientHttpUrls, AdvertisePeerUrls, AdvertiseClientUrls.
Following the same approach as in #17674, a linter ignore is added to these exported fields. However, non-exported functions and exported struct fields used only for JSON marshaling can be safely renamed.
Part of #17578.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.