Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/auth: simplify code for isValidPermissionRange #17816

Merged
merged 1 commit into from
Apr 20, 2024
Merged

server/auth: simplify code for isValidPermissionRange #17816

merged 1 commit into from
Apr 20, 2024

Conversation

callthingsoff
Copy link
Contributor

Not a big deal, but to make this function clearer.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @callthingsoff. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Not a big deal, but to make this function clearer.

Signed-off-by: Jes Cok <[email protected]>
@callthingsoff callthingsoff changed the title server/auth: simplify code in isValidPermissionRange server/auth: simplify code for isValidPermissionRange Apr 17, 2024
@ahrtr
Copy link
Member

ahrtr commented Apr 18, 2024

/ok-to-test

@callthingsoff
Copy link
Contributor Author

Ping @serathius, @ivanvc

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@serathius serathius merged commit 0b7bae2 into etcd-io:main Apr 20, 2024
45 checks passed
@callthingsoff callthingsoff deleted the simplify_isValidPermissionRange branch April 20, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants