tests/framework: address golangci var-naming issues #17651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Valdes <[email protected]>
20 tasks
ivanvc
commented
Mar 26, 2024
Comment on lines
+567
to
+568
| //revive:disable-next-line:var-naming | ||
| GrpcURL string |
There was a problem hiding this comment.
I'll address this change in a follow-up PR—the change yields about a hundred lines on changes.
serathius
approved these changes
Mar 26, 2024
ahrtr
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the
var-namingissues intests/framework.There are some exported variables that were renamed, but as they're in the tests directory, I didn't think they would need to be deprecated rather than just renamed.
Part of #17578.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.