-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix TestHashKVWhenCompacting
: ensure all goroutine finished
#17313
Conversation
Root cause:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensuring all goroutines finished is a good catch.
Have a question below about halving compaction count.
4bfeba7
to
7319a7a
Compare
7319a7a
to
f3071ed
Compare
TestHashKVWhenCompacting
: ensure all goroutine finished and reduce compaction countTestHashKVWhenCompacting
: ensure all goroutine finished
Tested the change, didn't see any difference in results
da0f2b1
to
f06c1c5
Compare
Signed-off-by: Benjamin Wang <[email protected]>
f06c1c5
to
c647614
Compare
/test pull-etcd-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @serathius |
Fix #17232
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.