Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci revive error-strings issues #17286

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 19, 2024

I was looking at the disabled linter rules and addressed the error-strings warnings. The only offending files are in the deprecated v2 client test code.

After speaking with @jmhbnz, he told me that @fuweid was working recently with the linter rules. So, it would be great if you could take a look at this.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ivanvc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz jmhbnz requested a review from fuweid January 19, 2024 19:35
@jmhbnz
Copy link
Member

jmhbnz commented Jan 19, 2024

/ok-to-test

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahrtr ahrtr merged commit 15f95ec into etcd-io:main Jan 21, 2024
40 checks passed
@ivanvc ivanvc deleted the fix-golangci-error-strings-issues branch April 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants