-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc: Printing etcd backend database related metrics inside scheduleCompaction function #17204
Conversation
Hi @rahulbapumore. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I left a comment in related issue #17179 (comment) Let's discuss it there. |
Please signoff the commit, |
Hi @ahrtr |
@@ -20,7 +20,7 @@ import ( | |||
"time" | |||
|
|||
"go.uber.org/zap" | |||
|
|||
humanize "github.com/dustin/go-humanize" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also put this item right above "go.uber.org/zap"
humanize "github.com/dustin/go-humanize" | |
humanize "github.com/dustin/go-humanize" | |
"go.uber.org/zap" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls keep the blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved
humanize "github.com/dustin/go-humanize"
above
"go.uber.org/zap"
Hi @ahrtr , |
scheduleCompaction function To improve traceability of backend database usage, Added below parameter related to backend database usage metrics inside scheduledCompaction function. current-db-size-bytes current-db-size current-db-size-in-use-bytes current-db-size-in-use Signed-off-by: Rahul More <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cc @serathius
Thanks @ahrtr for merging changes |
Hi @ahrtr , Thanks |
It will only be included in 3.6, and the release date isn't finalised yet. You want to backport the PR to 3.5 and. 3.4? I have no objection on it. |
Hi @ahrtr , Thanks |
It's OK for me. |
To improve traceability of backend database usage, Added below parameter related to backend database usage metrics inside scheduledCompaction function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use
Signed-off-by: Rahul More [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.