Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] etcd: upgrade go version from 1.20.10 to 1.20.11 #16915

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[3.5] etcd: upgrade go version from 1.20.10 to 1.20.11 #16915

merged 1 commit into from
Nov 13, 2023

Conversation

arjunmalhotra1
Copy link
Contributor

To keep etcd projects up to date with the latest patch releases & incorporate the latest security updates.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@serathius
Copy link
Member

Please sign DCO

@arjunmalhotra1
Copy link
Contributor Author

I see what you are saying @serathius So my commit does have
Signed-off-by: Arjun Malhotra <[email protected]>
I thought that would be sufficient 🤔

@jmhbnz
Copy link
Member

jmhbnz commented Nov 12, 2023

If you click "Details" next to the failing DCO (Developer certificate of origin) check you will see at the bottom:

Commit sha: 5447560, Author: arjunmalhotra1, Committer: arjunmalhotra1; Expected "arjunmalhotra1 [email protected]", but got "Arjun Malhotra [email protected]".

@arjunmalhotra1 arjunmalhotra1 force-pushed the release-3.5 branch 2 times, most recently from 85dbe23 to d255260 Compare November 12, 2023 22:21
jmhbnz
jmhbnz requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arjunmalhotra1 - I was expecting this backport to only be a patch version increase from 1.20.10 to 1.20.11 as described in the associated issue #16891.

I don't think the community has broadly agreed to bump minor version for stable version policy yet?

@arjunmalhotra1
etcd: upgrade go version from 1.20.10 to 1.20.11
e1aa1b9 
To keep etcd projects up to date with the latest patch releases &
incorporate the latest security updates.

Signed-off-by: arjunmalhotra1 <[email protected]>
@arjunmalhotra1 arjunmalhotra1 changed the title etcd: upgrade go version from 1.21.3 to 1.21.4 [3.5] etcd: upgrade go version from 1.21.3 to 1.21.4 Nov 13, 2023
@arjunmalhotra1 arjunmalhotra1 changed the title [3.5] etcd: upgrade go version from 1.21.3 to 1.21.4 [3.5] etcd: upgrade go version from 1.20.10 to 1.20.11 Nov 13, 2023
@arjunmalhotra1
Copy link
Contributor Author

Thanks @jmhbnz I have fixed it.

jmhbnz
jmhbnz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @arjunmalhotra1

@jmhbnz jmhbnz requested a review from ahrtr November 13, 2023 04:46
fuweid
fuweid approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahrtr
ahrtr approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks.

@ahrtr ahrtr merged commit a0cb92e into etcd-io:release-3.5 Nov 13, 2023
@jmhbnz jmhbnz mentioned this pull request Nov 13, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arjunmalhotra1 @serathius @jmhbnz @fuweid @ahrtr