Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-06-06: bump up dependencies update identified by dependabot #16023

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

chaochn47
Copy link
Member

@chaochn47 chaochn47 commented Jun 6, 2023

Summary of actions:

Pure indirect dependency in tools/mod/go.mod

Other indirect dependency

Other dependency update

Test workflow passed and merged already

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for keeping the docs up to date for the blocker with setup-protoc.

Note:

  • cfssl has an open pr now to bump go-sqlite3 so their next release should include that update.
  • go-grpc-middleware have removed github.com/sirupsen/logrus as a depdendency in later releases so once we can update that the indirect for logrus should go away.

Documentation/contributor-guide/dependency_management.md Outdated Show resolved Hide resolved
@chaochn47 chaochn47 force-pushed the 20230605-dependabot-dependency-mngt branch 2 times, most recently from 06e3c45 to 5c7314d Compare June 7, 2023 03:16
@chaochn47 chaochn47 force-pushed the 20230605-dependabot-dependency-mngt branch from 5c7314d to b2c39fc Compare June 7, 2023 03:18
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @chaochn47

@ahrtr ahrtr merged commit caee532 into etcd-io:main Jun 7, 2023
@chaochn47 chaochn47 deleted the 20230605-dependabot-dependency-mngt branch June 7, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants