Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/robustness: Use traffic.RecordingClient in watch #15959

Merged
merged 1 commit into from
May 26, 2023
Merged

tests/robustness: Use traffic.RecordingClient in watch #15959

merged 1 commit into from
May 26, 2023

Conversation

serathius
Copy link
Member

@serathius serathius force-pushed the robustness-watch-client branch from 1ad5704 to 16bf0f6 Compare May 25, 2023 20:17
jmhbnz
jmhbnz approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for improving some of the var names at the same time.

ahrtr
ahrtr approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius serathius merged commit 7cc98e6 into etcd-io:main May 26, 2023
@serathius serathius deleted the robustness-watch-client branch June 15, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @ahrtr @jmhbnz