Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove invalid arm64 workflow config #15829

Merged
merged 1 commit into from
May 4, 2023
Merged

remove invalid arm64 workflow config #15829

merged 1 commit into from
May 4, 2023

Conversation

chaochn47
Copy link
Member

@chaochn47 chaochn47 commented May 4, 2023 •
edited
Loading 

Warning: Unexpected input(s) 'ref', valid inputs are ['go-version', 'go-version-file', 'check-latest', 'token', 'cache', 'cache-dependency-path', 'architecture']

xref: #15647 (comment)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@chaochn47 chaochn47 force-pushed the remove_invalid_arm64_workflow_config branch from e6c82aa to e9b1a0e Compare May 4, 2023 22:33
jmhbnz
jmhbnz approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahrtr
ahrtr approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @chaochn47

@ahrtr
Copy link
Member

ahrtr commented May 4, 2023

Should we run arm64 workflow on 3.5 and 3.4 ? I think YES if we really want to mark it as tier-1 support. We can discuss this separately.

@ahrtr ahrtr merged commit b754994 into etcd-io:main May 4, 2023
@jmhbnz jmhbnz mentioned this pull request May 5, 2023
Closed
@chaochn47 chaochn47 deleted the remove_invalid_arm64_workflow_config branch May 13, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaochn47 @ahrtr @jmhbnz