Migrate grpc tests to common framework #15750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunil Shivanand <[email protected]>
Signed-off-by: Sunil Shivanand <[email protected]>
padlar
force-pushed
the
refactor-grpc-tests
branch
from
3066062 to
bf2d237
Compare
lavacat
reviewed
Apr 27, 2023
| defer cancel() | ||
| clus := testRunner.NewCluster(ctx, t, config.WithClusterConfig(tc.config)) | ||
| defer clus.Close() | ||
| cc := testutils.MustClient(clus.Client(tc.ClientOptions)) |
There was a problem hiding this comment.
there are compilation errors for tc.ClientOptions
| t.Helper() | ||
| requestsFound := 0 | ||
| for _, m := range clus.Members { | ||
| for _, r := range m.RecordedRequests() { |
There was a problem hiding this comment.
Not sure RecordedRequests will work here. You might have to wait for unified logging capture. See #15718 (comment)
| }, | ||
| { | ||
| name: "http://address[:port]", | ||
| useTCP: true, |
There was a problem hiding this comment.
there are compilation errors for useTCP
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating grpc tests mentioned here #13637