Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cockroachdb/datadriven to v1.0.2 to remove archived dependencies #15225

Merged

Conversation

pacoxu
Copy link
Contributor

@pacoxu pacoxu commented Jan 31, 2023

Signed-off-by: Paco Xu [email protected]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

I found that after etcd-io/raft#20 was merged, etcd v3.5.x was not updated.

So I sync the dependencies update to release-3.5 branch.

@ahrtr
Copy link
Member

ahrtr commented Jan 31, 2023

Please make sure your local go version is 1.17.13, then execute ./scripts/fix.sh

@pacoxu pacoxu force-pushed the update-cockroachdb/datadriven-etcd3.5 branch from 9ad2dea to 2a0ecd4 Compare January 31, 2023 06:42
@pacoxu
Copy link
Contributor Author

pacoxu commented Jan 31, 2023

Please make sure your local go version is 1.17.13, then execute ./scripts/fix.sh

Updated:

docker run --rm -it -v "$PWD":/usr/src/etcd -w /usr/src/etcd m.daocloud.io/docker.io/library/golang:1.17.13-bullseye bash
./scripts/fix.sh

I run the script in a golang:1.17.13 container and updated the PR.

@serathius serathius merged commit 238da4b into etcd-io:release-3.5 Jan 31, 2023
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
…riven-etcd3.5

upgrade cockroachdb/datadriven to v1.0.2 to remove archived dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants