Fixed goroutine leak in server/etcdserver/raft_test.go #14286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladSaioc
force-pushed
the
bugfix-goroutine-leak
branch
from
3a81b22 to
90bb7ac
Compare
Codecov Report
@@ Coverage Diff @@
## main #14286 +/- ##
==========================================
- Coverage 75.69% 75.30% -0.39%
==========================================
Files 456 456
Lines 37036 37036
==========================================
- Hits 28035 27891 -144
- Misses 7273 7389 +116
- Partials 1728 1756 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahrtr
reviewed
Jul 31, 2022
server/etcdserver/raft_test.go
Outdated
| @@ -171,6 +171,7 @@ func TestStopRaftWhenWaitingForApplyDone(t *testing.T) { | |||
| select { | |||
| case <-srv.r.applyc: | |||
| case <-time.After(time.Second): | |||
| srv.r.stop() | |||
There was a problem hiding this comment.
The srv.r.stop() may be blocked. I would suggest to follow the same way as line 178 ~ 183, which can be wrapped in a function.
Signed-off-by: VladSaioc <[email protected]>
VladSaioc
force-pushed
the
bugfix-goroutine-leak
branch
from
90bb7ac to
6cded3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package: etcdserver
Potential for goroutine leak in TestStopRaftWhenWaitingForApplyDone. Timeout case will lead raft node goroutine to block at a select statement. Stopping raft node before calling
t.Fatalfwill unblock the select and terminate the child goroutine.