[3.4] Fix pipeline failure for release test #14210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
force-pushed
the
fix_release_script
branch
7 times, most recently
from
d5a4ad7 to
5cda87d
Compare
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
fix_release_script
branch
from
5cda87d to
be0ce4f
Compare
|
The reason why the release pipeline fails on release-3.4 but succeeds on release-3.5 is we clone local directory instead of the remote repo in release-3.5, so we can still see the tag The failure for this PR is because the change (this PR) hasn't been merged into release-3.4 yet. Each time when running the release pipeline, it just clones the remote repo and run the test again release-3.4. @serathius @spzala @ptabor So we need to merge this PR firstly. Please take a look. thx |
ahrtr
changed the title
serathius
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Wang [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.