-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Repeat functional tests for 1 minute #13926
Conversation
efdd512
to
de28ce6
Compare
Codecov Report
@@ Coverage Diff @@
## main #13926 +/- ##
==========================================
- Coverage 72.41% 72.38% -0.03%
==========================================
Files 469 469
Lines 38411 38411
==========================================
- Hits 27814 27804 -10
- Misses 8798 8816 +18
+ Partials 1799 1791 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
de28ce6
to
d8be293
Compare
d8be293
to
d676b13
Compare
@@ -191,30 +191,42 @@ func (clus *Cluster) doTestCase(t *testing.T, fa Case) { | |||
} | |||
stressStarted = true | |||
} | |||
done := time.After(time.Minute) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make the duration configurable or add a TODO note here?
Need to rethink if we prefer to have 1 failure injection per test and run multiple tests or have multiple injections per test. Decision should depend on how it's easier to adjust the runs in different scenarios:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Data corruption was only found when functional failure injections was executed multiple times for period of 1 minute. Executing failure once is not enough to confirm if issue exist.