CHANGELOG: update from #11711 #11790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11790 +/- ##
==========================================
- Coverage 66.49% 66.08% -0.41%
==========================================
Files 403 403
Lines 36881 36881
==========================================
- Hits 24524 24374 -150
- Misses 10855 10996 +141
- Partials 1502 1511 +9
Continue to review full report at Codecov.
|
spzala
requested changes
Apr 16, 2020
CHANGELOG-3.5.md
Outdated
| @@ -148,6 +148,7 @@ Note that any `etcd_debugging_*` metrics are experimental and subject to change. | |||
| ### gRPC Proxy | |||
|
|
|||
| - Fix [`panic on error`](https://github.com/etcd-io/etcd/pull/11694) for metrics handler. | |||
| - Add gRPC keep alive related flags `grpc-keepalive-min-time`, `grpc-keepalive-interval` and `grpc-keepalive-timeout`. | |||
There was a problem hiding this comment.
Thanks @mlmhl - couple of suggestions that please use keepalive as one word, and hyperlink to the PR.
There was a problem hiding this comment.
Thanks for the reminder, fixed, PTAL:)
|
@mlmhl :) yrw and thanks for addressing the comments. LGTM. |
spzala
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CHANGELOG for #11711 .