Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #11621 to release-3.4 #11636

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Automated cherry pick of #11621 to release-3.4 #11636

merged 1 commit into from
Feb 20, 2020

Conversation

YoyinZyc
Copy link
Contributor

@jingyih @YoyinZyc
etcdserver: corruption check via http
770674e 
During corruption check, get peer's hashKV via http call.
@YoyinZyc
Copy link
Contributor Author

Also, can we cut a new 3.4 release after merging this PR by this weekend? Recent corruption fix and corruption checker improvement are pretty worth to make a new release. @gyuho

@YoyinZyc YoyinZyc requested review from gyuho and jingyih February 19, 2020 18:39
@YoyinZyc YoyinZyc mentioned this pull request Feb 19, 2020
Merged
@gyuho
Copy link
Contributor

gyuho commented Feb 19, 2020

yeah, can we take a look at CI failures.

I can do the release.

@YoyinZyc
Copy link
Contributor Author

yeah, can we take a look at CI failures.

I can do the release.

Thanks! The failure is the commit_title check complaining about a previous commit title. It is not about this PR.

bb5ba14 Add version, tag and branch checks to release script...
Expected commit title format '<package>{", "<package>}: <description>'
Got: bb5ba14 Add version, tag and branch checks to release script

@YoyinZyc
Copy link
Contributor Author

Btw, can I ask when can we have this new release? It will be great we can get it by this Friday. Thanks. @gyuho

jingyih
jingyih approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingyih jingyih merged commit cdb2dc1 into etcd-io:release-3.4 Feb 20, 2020
@tangcong tangcong mentioned this pull request Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih approved these changes

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoyinZyc @gyuho @jingyih