pkg: remove capnslog #11616
Merged
pkg: remove capnslog #11616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
commented
Feb 12, 2020
etcdmain/config.go
Outdated
| @@ -321,7 +321,7 @@ func (cfg *config) configFromCmdLine() error { | |||
| } | |||
| } | |||
|
|
|||
| err := flags.SetFlagsFromEnv("ETCD", cfg.cf.flagSet) | |||
| err := flags.SetFlagsFromEnv(cfg.ec.GetLogger(), "ETCD", cfg.cf.flagSet) | |||
There was a problem hiding this comment.
Note: At this point, I don't think user-configured zap logger is properly setup yet. Should we use zap.NewProduction() or maybe a different logger?
There was a problem hiding this comment.
zap.NewProduction should be fine.
gyuho
approved these changes
Feb 12, 2020
jingyih
force-pushed
the
remove_capnslog_in_pkg
branch
from
84b85b4 to
912c8bf
Compare
|
@jingyih can you resolve the conflict in the changlog? thanks. |
jingyih
force-pushed
the
remove_capnslog_in_pkg
branch
from
912c8bf to
81d9872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency of
capnsloginpkgpackage.Related: #11426