Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: fix user.Options nil pointer #11413

Merged
merged 1 commit into from
Dec 2, 2019
Merged

auth: fix user.Options nil pointer #11413

merged 1 commit into from
Dec 2, 2019

Conversation

YoyinZyc
Copy link
Contributor

@YoyinZyc YoyinZyc commented Dec 2, 2019

jingyih
jingyih approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiang90
Copy link
Contributor

xiang90 commented Dec 2, 2019

need backport?

@jingyih
Copy link
Contributor

jingyih commented Dec 2, 2019

need backport?

Yes this is also in 3.4.

@xiang90 xiang90 merged commit ae2bc16 into etcd-io:master Dec 2, 2019
jingyih added a commit that referenced this pull request Dec 2, 2019
@jingyih
Merge pull request #11415 from YoyinZyc/automated-cherry-pick-of-#114…
ac63c2f 
…13-upstream-release-3.4

Automated cherry pick of #11413 to release-3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade from 3.3.18 to 3.4.3 panic
3 participants
@YoyinZyc @xiang90 @jingyih