-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc/kvstore: Optimize compaction, slove conflict for #11150 #11330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11330 +/- ##
=========================================
+ Coverage 64.05% 64.26% +0.2%
=========================================
Files 403 403
Lines 37970 37969 -1
=========================================
+ Hits 24323 24400 +77
+ Misses 12011 11940 -71
+ Partials 1636 1629 -7
Continue to review full report at Codecov.
|
Code change looks good to me. Could you please clean up the commits? |
LGTM |
…ompact take too long and blocks other requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test failure unrelated. |
…0-upstream-release-3.4 Cherry pick of #11330 on release-3.4
mvcc/kvstore: Optimize compaction
when the number of key-value index is greater than one million, compact take too long and blocks other requests.
Move the “kvindex.Compact” to “fifoSched.Schedule” func
slove conflict for #11150