Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.2 #11271

Conversation

wenjiaswe
Copy link
Contributor

@wenjiaswe wenjiaswe commented Oct 17, 2019

Cherry pick of #10257, #11233, #11254, #11265 on release-3.2.

XREF: #11261

@wenjiaswe wenjiaswe changed the title Automated cherry pick of #11261 cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.2 Oct 17, 2019
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@gyuho
Copy link
Contributor

gyuho commented Oct 17, 2019

@wenjiaswe @jingyih @YoyinZyc Can we update the CHANGELOG with all the recent changes, in a batch? Thanks!

@wenjiaswe
Copy link
Contributor Author

@gyuho Yes, we will work on this.

wenjiaswe added a commit that referenced this pull request Oct 17, 2019
Add changelog for etcd_cluster_version metrics from ##11271
@wenjiaswe
Copy link
Contributor Author

@gyuho @jpbetz could we have a new 3.2 release after merging of this PR?

@gyuho
Copy link
Contributor

gyuho commented Oct 17, 2019

@wenjiaswe Sure, I will sometime next week.

@gyuho gyuho merged commit db9f5b0 into etcd-io:release-3.2 Oct 17, 2019
gyuho added a commit that referenced this pull request Oct 17, 2019
@wenjiaswe
Copy link
Contributor Author

cc @andyliuliming, looks like we will have a new 3.2 release next week.

@wenjiaswe wenjiaswe deleted the automated-cherry-pick-of-#11261-upstream-release-3.2 branch October 22, 2019 17:33
@andyliuliming
Copy link
Contributor

@wenjiaswe any good news about the 3.2.28? :)

@wenjiaswe
Copy link
Contributor Author

Cc @hexfusion

@hexfusion
Copy link
Contributor

hexfusion commented Oct 28, 2019 via email

wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Nov 11, 2019
Add changelog for etcd_cluster_version metrics from #etcd-io#11271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants