Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftexample: added build instruction and minor refactoring #10496

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

trung
Copy link
Contributor

@trung trung commented Feb 21, 2019

When trying out raftexample, there's no instruction on how to build the source. So i added few steps to make it clearer to the user.

Also using defer to unlock mutex in couple of places in kvstore.go.

@codecov-io
Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #10496 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10496      +/-   ##
==========================================
- Coverage   71.57%   71.54%   -0.03%     
==========================================
  Files         392      392              
  Lines       36518    36518              
==========================================
- Hits        26136    26128       -8     
- Misses       8552     8556       +4     
- Partials     1830     1834       +4
Impacted Files Coverage Δ
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
proxy/grpcproxy/watcher.go 85.71% <0%> (-4.09%) ⬇️
etcdserver/api/v3rpc/watch.go 80.06% <0%> (-3.93%) ⬇️
etcdserver/util.go 95% <0%> (-3.75%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
etcdserver/api/v3election/election.go 66.66% <0%> (-2.78%) ⬇️
proxy/grpcproxy/watch.go 89.75% <0%> (-1.81%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
clientv3/op.go 73.93% <0%> (-0.86%) ⬇️
clientv3/leasing/kv.go 89.03% <0%> (-0.67%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c228d6...5b4ff6c. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Feb 26, 2019

lgtm

@xiang90 xiang90 merged commit a7e3bd0 into etcd-io:master Feb 26, 2019
@trung trung deleted the raft-example branch February 26, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants