lease: fix deadlock with Renew lease when the checkpointor is set #10492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @WIZARD-CXY can you take a look? |
|
will do |
hormes
reviewed
Feb 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #10492 +/- ##
==========================================
- Coverage 71.83% 71.6% -0.23%
==========================================
Files 392 392
Lines 36518 36520 +2
==========================================
- Hits 26231 26150 -81
- Misses 8464 8542 +78
- Partials 1823 1828 +5
Continue to review full report at Codecov.
|
|
ci passed. PTAL |
WIZARD-CXY
suggested changes
Feb 23, 2019
Signed-off-by: nolouch <[email protected]>
WIZARD-CXY
reviewed
Feb 25, 2019
|
/cc @jpbetz |
|
lgtm. defer to @jpbetz |
|
PTAL @jpbetz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch [email protected]
There is a deadlock issue which block the write. when we renew a lease that have remaining TTL cause by the long TTL setting, it write
lease checkpointingentry to raft and wait it apply, but apply this entry also need acquire the same lock which already acquired byrenew, and then meet the deadlock until timeout.