docs: add note about version, remove old Vagrantfile #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On further thought I think we should just remove the build instructions from the README entirely for no and point people towards the releases. |
|
|
||
| etcd has known issues on 32bit systems. We plan to address these issues after the 0.4 release. | ||
| etcd has known issues on 32-bit systems. |
There was a problem hiding this comment.
I think this is due to the Go runtime so we should mention that.
|
lgtm |
| @@ -30,28 +38,7 @@ The latest release and setup instructions are available at [GitHub][github-relea | |||
|
|
|||
| [github-release]: https://github.com/coreos/etcd/releases/ | |||
|
|
|||
|
|
|||
| ### Building | |||
There was a problem hiding this comment.
why do we remove this section?
There was a problem hiding this comment.
I don't think we should be encouraging people to build it right now as it is just going to cause confusion.
If they are going to use etcd, right now we want them to use 0.4.x.
What do you think?
There was a problem hiding this comment.
Right. This is reasonable since we have a WARNING section.
jonboulle
force-pushed
the
master
branch
2 times, most recently
from
33b0931 to
d8b9e06
Compare
|
lgtm |
xiang90
added a commit
that referenced
this pull request
Sep 8, 2014
docs: add note about version, remove old Vagrantfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.